Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rds): configure autoMinorVersionUpgrade for a database cluster #31962

Merged
merged 8 commits into from
Nov 1, 2024
Merged

feat(rds): configure autoMinorVersionUpgrade for a database cluster #31962

merged 8 commits into from
Nov 1, 2024

Conversation

badmintoncryer
Copy link
Contributor

@badmintoncryer badmintoncryer commented Oct 31, 2024 •
edited
Loading

Issue # (if applicable)

None

Reason for this change

We can configure `autoMinorVersionUpgrade' for a database cluster, but AWS CDK cannot do this.

Description of changes

Add autoMinorVersionUpgrade to DatabaseClusterBaseProps.

Description of how you validated changes

Add both unit and integ tests.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Oct 31, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team October 31, 2024 14:52
@github-actions github-actions bot added the distinguished-contributor [Pilot] contributed 50+ PRs to the CDK label Oct 31, 2024
@badmintoncryer badmintoncryer marked this pull request as ready for review October 31, 2024 14:54
aws-cdk-automation
aws-cdk-automation previously requested changes Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation dismissed their stale review October 31, 2024 15:06

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 31, 2024
sumupitchayan
sumupitchayan reviewed Oct 31, 2024
View reviewed changes
packages/aws-cdk-lib/aws-rds/README.md
@@ -118,6 +118,20 @@ new rds.DatabaseClusterFromSnapshot(this, 'Database', {
});
```

By default, automatic minor version upgrades for the engine type are enabled in a cluster, but you can also disable this.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CFN docs for reference: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-rds-dbinstance.html#cfn-rds-dbinstance-autominorversionupgrade

sumupitchayan
sumupitchayan approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@sumupitchayan sumupitchayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me here @badmintoncryer, thanks for the PR

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 31, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 31, 2024
@badmintoncryer
Copy link
Contributor Author

@mergify update

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 1, 2024

update

✅ Branch has been successfully updated

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 1, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 8f0ea03
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 0fb6106 into aws:main Nov 1, 2024
9 checks passed
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 1, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 1, 2024
@badmintoncryer badmintoncryer deleted the autoMinorVersionUpgrade branch November 1, 2024 02:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sumupitchayan sumupitchayan sumupitchayan approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@badmintoncryer @aws-cdk-automation @sumupitchayan